search

fountainhead / action-wait-for-check

A GitHub Action that waits for another Check Run to have completed
MIT License
122 stars 44 forks source link

Update nodeJS to v16 #34

Closed sammcj closed 2 years ago

sammcj commented 2 years ago

This PR updates this action from nodeJS 12 to 16 which is now the minimum version supported by Github Actions.

I also bumped the actions/checkout version from v1 to v3 as that is what is also supported by Github.

Note that there are a lot of very out of date dependencies in the package.json, many have serious security vulnerabilities and should be addressed - but that is seperate from this PR.

@fountainhead / @wms

fixes:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: fountainhead/action-wait-for-check

wms commented 2 years ago

@sammcj Thanks for the PR. I can't see anything wrong with the changes proposed, but in addition to the dependency updates you suggest in your comment, there's slew of other issues with this Action (see the pile of neglected PRs and broken build on this PR.)

Let me see if I can find some time this morning to fix this project back up.

wms commented 2 years ago

I've changed the base to a topic branch that I'll use to assemble other fixes on as well.