four-man-army / nextjs_password_safe

This is the most safe password safe
https://password-safe.ch
MIT License
2 stars 0 forks source link

[Bug]: Playwright workflow #24

Closed oliver-oswald closed 1 year ago

oliver-oswald commented 1 year ago

Contact Details

No response

What happened?

PLaywright doesn't know the url inthe config file htere is alse a mistake in the .yml file

name: Playwright Tests
on:
  push:
    branches: [ main, beta ]
  pull_request:
    branches: [ main, beta ]
jobs:
  test:
    timeout-minutes: 60
    runs-on: ubuntu-latest
    steps:
    - name: extract current branch
      run: |
        CURRENT_BRANCH=$(echo $GITHUB_REF | sed -e 's/refs\/heads\///g' | sed -e 's/_//g')
        URL=https://nextjs-password-safe-git-$CURRENT_BRANCH-four-man-army.vercel.app/
        echo $CURRENT_BRANCH
        echo $URL
    - name: create env file
      run: |
        touch .env
        echo PASSWORD=${{secrets.PASSWORD}} >> .env
        echo EMAIL=${{secrets.EMAIL}} >> .env
        echo TEST_URL=$URL >> .env
        echo CI=true >> .env
    - uses: actions/checkout@v3
    - uses: actions/setup-node@v3
      with:
        node-version: 16
    - name: Install dependencies
      run: npm ci
    - name: Install Playwright Browsers
      run: npx playwright install --with-deps
    - name: Run Playwright tests
      run: npm run test
      env:
        PASSWORD: ${{secrets.PASSWORD}}
        EMAIL: ${{secrets.EMAIL}}
        TEST_URL: $URL
    - uses: actions/upload-artifact@v3
      if: always()
      with:
        name: playwright-report
        path: playwright-report/
        retention-days: 30

Version

1.0.2 (Default)

What browsers are you seeing the problem on?

No response

Relevant log output

> password_safe@0.1.0 test
> playwright test

baseURL $URL

Running 9 tests using 1 worker

TypeError: Invalid URL

  9 skipped
  1 error was not a part of any test, see above for details

Code of Conduct

oliver-oswald commented 1 year ago

finally solved the issue