fourMs / MGT-python

Musical Gestures Toolbox for Python
https://www.uio.no/ritmo/english/research/labs/fourms/downloads/software/musicalgesturestoolbox/mgt-python/index.html
GNU General Public License v3.0
52 stars 11 forks source link

ffmpeg_cmd and ffmpeg_cmd_async should raise exception if something goes wrong #227

Closed balintlaczko closed 3 years ago

balintlaczko commented 3 years ago

...instead of misleadingly printing 'Progress 100%'. The exception should print stderr.

balintlaczko commented 3 years ago

Now they do, but I accidentally introduced a regression of not showing progress. FFmpeg does not separate warnings or notes from errors, instead just logs everything into STDERR. And -loglevel error is not a fix (exhibit A...) because it will remove the frame=... progress messages too, basically everything. So have to figure out a way to be able to show progress, but at the same time reliably detect error messages (and distinguish them from warnings).

balintlaczko commented 3 years ago

Manual cropping should also be "gracefully" (automatically) disabled in Colab.

balintlaczko commented 3 years ago

ffmpeg_cmd now raises its FFmpegerror correctly, and can also report progress. Retired the asynchronous version, since the implementation would cost too much time, while there is not much need for this to be async.