Closed NguyenTrung1995 closed 6 years ago
@NguyenTrung1995
Please add the editor config into https://github.com/fourdigit/editorconfig-config-fourdigit , not do work on this repository.
If the project contain .editorconfig file, we will add rules that it does not. I think this behavior is may not good.
Let me explain with a example.
Alice: Developer 1(who make repo & config file of editoconfig) Bob: Developer 2(who clone the repository that Alice made)
.editorconfig
)yarn add @fourdigit/eslint-config-fourdigit
git commit
& git push
git push
eslint-config-fourdigit
run automatically & editorconfig is modified by the scriptEverytime other developer joins, the burden occurs. So, the strategy "If the project contain .editorconfig file, we will add rules that it does not." might not better.
Instead of adding the feature, please add a instruction to update editorconfig. e.g.
## Update .editorconfig
When this package is installed & no `.editorconfig` file is existed on your project, npm automatically copies the config from `ndoe_modules/@fourdigit/editorconfig-config-fourdigit/.editorconfig` to project root.
When you want to update your editorconfig manually, please run following command.
cp './node_modules/@fourdigit/editorconfig-config-fourdigit/.editorconfig' .editorconfig
To do