search

fourdigits / django-template-lsp

GNU General Public License v3.0
18 stars 0 forks source link

Add `--version` option feature #16

Closed yaegassy closed 4 months ago

yaegassy commented 4 months ago

Description

Hi. Thank you for creating a wonderful language server.

By the way, I have added a --version option to the djlsp (django-template-lsp) command.

Screen shot

djlsp-add-version-option
krukas commented 4 months ago

Thanks for the contribution

yaegassy commented 4 months ago

@krukas Thank you for merging the pull request. By the way, I have some ideas for additional features, not feature requests.

It might not be possible to retrieve document information for tags and filters with the parser. However, if you can provide document information, I believe it would be possible to implement COMPLETION_ITEM_RESOLVE and HOVER.

yaegassy commented 4 months ago

Currently, I think the django_settings_module needs to be explicitly set for each project.

If the language server is creating an index for the entire project at startup, it would be very convenient if it could be auto-detected.

krukas commented 4 months ago

@yaegassy I have added issues for your suggestions. We already have an index for the whole project: https://github.com/fourdigits/django-template-lsp/blob/main/djlsp/index.py this is indexed/collected with: https://github.com/fourdigits/django-template-lsp/blob/main/djlsp/scripts/django-collector.py