search

fourier / ztree

Directory tree comparison mode for Emacs
http://www.emacswiki.org/emacs/ZtreeDiff
GNU General Public License v3.0
239 stars 21 forks source link

no difference in mismatch files #29

Closed ramestica closed 7 years ago

ramestica commented 9 years ago

Hi,

all files are marked as different (red). For a moment I though that it was some highlighting issue in my configuration, but if I try to customize one of the file names in red (which I know are otherwise identical files) then I get ztreep-diff-model-diff-face, which I suppose it really means that ztree thinks those two files are different.

My problem is so basic that it should be something wrong in my configuration. Any hint for anything I should be looking for?

Thanks, Rodrigo

fourier commented 9 years ago

Can you try to run emacs -q, load ztree and run the ztree-diff again with the same directories?

ramestica commented 9 years ago

while testing 'emacs -q' it dawned in my mind that perhaps the problem happens to me only on remote directories accessed through tramp. And sure enough, with -q or with my own emacs configuration files are all marked as different when they are located in remote directories. On local directories only files that differ are marked a so.

So, it must be something related to comparing the files through tramp.

fourier commented 9 years ago

Yes, I've never tested with TRAMP neither it was my aim. @Silex reported what the TRAMP works and even suggested a patch for it. Personally I don't know how could it work since the main 'backend' of the ztree-diff is a simple diff command. See Issue #7

Silex commented 8 years ago

Oops. Sorry I somehow missed the @Silex mention, you're right it seems to bug when diffing remote files (all files are marked as different). I'll see what I can do.

Silex commented 8 years ago

Ok, the problem was introduced with https://github.com/fourier/ztree/commit/32db847e4545483bdb08d6facdb8bb9887fb6d6d

I'm making a PR to correct it.

Silex commented 8 years ago

@ramestica: please test the PR fixes it for you.

Silex commented 8 years ago

@fourier: for your information, the diff command runs over TRAMP too, that's why it works (the diff is executed on the remote host).

ramestica commented 8 years ago

the PR fixes the problem.

Many thanks