Fix TRAMP regression

[Silex]

Will fix #29.

Don't merge it yet I'm trying to fix some FIXMEs (detection of different hosts, etc)

[Silex]

@fourier: okay, you can merge

[fourier]

it looks like your changes started to be non-trivial. Could you please sign the FSF papers? It will take some time. Please read here: https://github.com/fourier/ztree/#copyright-issues

[Silex]

Yawn. Ok I hope at least the FSF papers will work for all GNU projects...

I sent it, I'll keep you updated.

[fourier]

Typically you specify the project to work on. I specified "Emacs" and it covers GNU ELPA as well as I understood.

[Silex]

I wrote that if possible I'd like it to include GNU* in order to avoid having to send these again :-)

[Silex]

Papers sent.

[fourier]

Thanks let me know when you get the response from FSF and we can start accepting changes.

[Silex]

Hey, I just noticed this:

https://github.com/fourier/ztree/blob/master/ztree-diff-model.el#L152

Do you agree the -modef part is useless? shall I remove it? or was it a typo and it should be -model?

[Silex]

@fourier: ping

[Silex]

@fourier: I received the documents! The assignment was successful

[fourier]

Perfect, thanks. I'll review the patch later this week and test myself with remote connections.

[Silex]

@ramestica: mentionning you here so you know when the PR is merged.

[fourier]

@Silex I've also tried to test what you've done. I've created 2 directories on a remote server with almost identical contents (one file is different and one directory is missing), but got all-red results:

It looks like diff was not running on a remote server. I've run the ztree-diff with Emacs 24.5.1 started with the -Q key to ensure no other packages involved.

[Silex]

Alright, I did the requested changes.

About your test, you need to show more information... as you can see on my screenshot, it works (started with emacs -Q, version 25.1.50.2 but it worked fine on 24.5.1 when I tested at work).

How did you connect to the remote server? what TRAMP protocol did you use? I ask because it won't work with all TRAMP protocols (e.g FTP).

[fourier]

I've used tramp ssh.

[Silex]

@fourier: once connected to a TRAMP host, try M-x eval-expression (shell-command-to-string "ls") RET

It should print the remote files... If that works, I suggest you run your test again. If it still fails, I'll make a testcase in the form of emacs -Q -f testcase.el which you can run.

[Silex]

@ramestica: can you test this PR and confirm the fix works for you? The commits changed a bit.

[Silex]

@fourier: were you able to test again?

[fourier]

No I was not able to test. Waiting for response of @ramestica.

[ramestica]

present PR works good to me.

[fourier]

Thanks, merged!

[Silex]

:+1: