fourier / ztree

Directory tree comparison mode for Emacs
http://www.emacswiki.org/emacs/ZtreeDiff
GNU General Public License v3.0
239 stars 21 forks source link

Fix TRAMP regression #43

Closed dvzubarev closed 7 years ago

dvzubarev commented 7 years ago

file-attributes accepts trampified paths, otherwise it looks for local files.

fourier commented 7 years ago

Thanks, I don't use ztree over TRAMP so can't test. @Silex does this fix works for you?

Silex commented 7 years ago

The fix looks correct. I see that you attempted to make TRAMP faster by checking the file size instead of doing the diff, but based on the latest comment in #18 it looks like it's still slow.

You'd really set up a test for this, that way you actually can measure differences and regressions.

The test would be fairly simple: have directory A and B (which is a copy of A with differences).

Repeat and have 3-4 different A & B as input.

fourier commented 7 years ago

Ok I'll accept the fix then.

fourier commented 7 years ago

Merged, thanks @dvzubarev !