Open shaal opened 7 years ago
@shaal Do you think it would be better to leave the phrase "emulsify" in some of these files rather than replace it (currently the drush script is an all or nothing within each file)?
We had considered making templates for these files so that exact lines could be replaced but would also need to setup some sort of build system so that the example theme would continue to work. It would also mean that contributors would need to make changes to the template files instead of the "built" files which might make it more complicated to maintain down the road. I would love to hear your ideas on this subject.
Yeah, I can see what you’re talking about. We might not want to replace within documentation files, etc. This is a really useful comparison. I’ll take a more thorough look when I have a minute
Is this still an issue since moving to the php script?
Yes, this is really a larger issue of needing template files.
after running
drush emulsify mynewtheme
comparing the original emulsify theme and the cloned themediff -bur contrib/emulsify custom/mynewtheme
show some data that was cloned and renamed to the new theme, even when it doesn't make sense and creates unusable links (i.e. https://github.com/fourkitchens/mynewtheme)
below is the full output of that comparison -