Closed heatherwoz closed 3 years ago
@heatherwoz
Changes here:
Awesome! I'm now going to get in the habit of creating pull requests for you to review rather than just committing directly to the main
branch.
for D8, import config after running DB updates rather than before - there is some debate, but this seems to be the recommended practice; it was necessary for the 8.8 -> 8.9/9 upgrades
Weird. That feels backwards to me. I can think of some scenarios where that won't work. But I'm having trouble thinking of scenarios why this change would be needed.
Regardless, I think 95% of the time it shouldn't matter which order, so I'm willing to give it a shot and see how this plays out in the real world.
Changes here: