search

fourkitchens / pantheon-tools

Tools to run actions against a Pantheon site
GNU General Public License v3.0
16 stars 3 forks source link

Several errors with `pantheon-module-report` #5

Open dalin- opened 2 years ago

dalin- commented 2 years ago

Since we merged the Advo + 4K clients together, the pantheon-module-report needs to deal with more edge cases. It would be great if it could handle these errors better:

$ pantheon-module-report system
Also list sites that don't have the module? (Y/N) y
...
stanford-hs.live : not found or not enabled

Huh? This is a valid D8/9 site, the live environment exists, we know that Drush works on this site. Why do we get this error? There's several similar errors with other sites. 

Cannot determine the version of Drush.  Proceeding assuming that everything is going to work out fine.
advostarter-d8.live : not found or not enabled

Very strange. I'm not sure that the live env. is set up on this site. But it should just fall back to the dev site when that happens. Needs more investigation. 

/Users/dave/Sites/pantheon-tools/functions/drupal/drupal-get-drush-version: line 50: [: : integer expression expected
/Users/dave/Sites/pantheon-tools/pantheon-module-report: line 47: [: : integer expression expected
/Users/dave/Sites/pantheon-tools/functions/drupal/drupal-get-drush-version: line 50: [: : integer expression expected
/Users/dave/Sites/pantheon-tools/pantheon-module-report: line 47: [: : integer expression expected
vr-editor: Could not run drush commands against the live or dev environments.

There's a few sites like this. They are probably really old sites. It looks like our code is having trouble parsing the version string. Can we get this working better?

duncancm9 commented 1 year ago

Another issue that arises with this command is that some sites may prompt for a password if you are part of an org that is a supporting workspace for another org, but you don't have access to the test or live environments.