fourkitchens / scrummy-react-dom

♠️♣️♥️♦️
http://playscrummy.com
5 stars 4 forks source link

Warning on build if local.yaml doesn't exist #29

Closed ccjjmartin closed 7 years ago

ccjjmartin commented 7 years ago

Purpose:

Note to reviewer:

Reproduce warning:

Notes:

Testing:

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #29 into master will not change coverage

@@           master   #29   diff @@
===================================
  Files          13    13          
  Lines         119   119          
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits          119   119          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 5009e80...713f468

infiniteluke commented 7 years ago

To answer your question about local config, I only have apiUrl: ws://localhost:8001 in my local.yml 👍

ccjjmartin commented 7 years ago

@infiniteluke Thanks for the quick reviews on these. I updated the docs for your comments except the one about sp "projects". I haven't seen the abbreviation sp before. I am guessing that is spelling error. If so, I went with the plural of "projects" to refer to both projects rather than the possessive "project's" which would seem to only refer to one. I can update this to "project's" if you prefer though. Let me know if sp means something else.

infiniteluke commented 7 years ago

Hey @ccjjmartin - Yes, sp was a bit cryptic, but you're right, I meant spelling error. In this case we'll still want to use projects' since it is possessive of their directories and there are multiple of them (server/client).