search

fourkitchens / scrummy-react-dom

♠️♣️♥️♦️
http://playscrummy.com
5 stars 4 forks source link

refactor(containers): Remove unecessary containers and pass props. #36

Closed infiniteluke closed 7 years ago

infiniteluke commented 7 years ago

NOTE: When merging, squash and add "Closes #35" to commit footer.

codecov-io commented 7 years ago

Codecov Report

Merging #36 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         127    127           
=====================================
  Hits          127    127
Impacted Files Coverage Δ
src/components/VotingResult/index.js 100% <100%> (ø) :arrow_up:
src/components/Hand/index.js 100% <100%> (ø) :arrow_up:
src/components/Card/index.js 100% <100%> (ø) :arrow_up:
src/containers/Card.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fdd932...65738e3. Read the comment docs.

infiniteluke commented 7 years ago

Currently not checking in shouldComponentUpdate because the re-renders were shallow and perf difference was negligible. 2-4ms.