search

fourshade / spectra_lexer

Stroke and rule analyzer for stenography
GNU General Public License v2.0
35 stars 3 forks source link

Add more punctuation #3

Closed Abkwreu closed 4 years ago

Abkwreu commented 4 years ago

Add rules for ? (question mark), ! (exclamation mark), : (colon), ; (semicolon), ... (ellipsis points), and KPA (capitalize next word)

fourshade commented 4 years ago

I fixed up the shapes and merged those in the new format. Some comments:

  1. Some of the shapes had waaaaaay too many redundant nodes. Here's what one looks like in Inkscape:

    nodes

    There's over 100 nodes packed into the corner on the left; a circular corner only requires two, like the one on the right. If you noticed that the path codes were 10 times longer than any other shape, this is why. I'm not sure what editor you used to generate these, but most vector editors will have a "simplify" command that gets rid of all of these extra nodes. Fewer nodes means smaller files and faster rendering.

  2. One of the shapes was unused and also identical to a previous shape. I suspect this was left over from messing around, but a PR should only have the finished work committed.

  3. Try to keep to relative coordinates if you can; it makes it easier to move things around. If everything except the starting point (Mx,y) is relative, the entire shape can be easily moved by changing just that point. For example, KPA had its origin at 'S' despite not touching that column, but it couldn't be moved to the 'T' column easily since the coordinates were a mix of relative and absolute. This is something editors will let you customize as well. Mixed coordinate modes are only useful for shaving a few characters off the size of a finished SVG file. The steno boards are made dynamically by composing a bunch of these shape paths, so the flexibility of relative coordinates is very useful here.

I'll probably start overhauling the rules format shortly, so it might be a good idea to hold off on changing your rules until then.