search

foursquare / fsqio

A monorepo that holds all of Foursquare's opensource projects
Apache License 2.0
252 stars 54 forks source link

Fix buildgen for targets with defaulted names #31

Closed toddgardner closed 7 years ago

toddgardner commented 7 years ago

Pant's BUILD name field is now optional and defaults to the basename of the directory it's in; this patches buildgen to support that.

Not sure if there's tests somewhere for this.

mateor commented 7 years ago

Hi Todd - thanks for the pull request. I landed this internally and gave it a spin. Looked good to me. It is actually missing the import os but I amended it in.

It is deployed internally and should show up in the next update of Fsq.io. Thanks for the contributions!