foursquare / fsqio

A monorepo that holds all of Foursquare's opensource projects
Apache License 2.0
254 stars 54 forks source link

Update PrefixIndexer.scala #56

Closed jglesner closed 5 years ago

jglesner commented 6 years ago

To address Issue #53 (https://github.com/foursquare/fsqio/issues/53), which has to do with regex parsing errors caused during processing of prefixes, I have wrapped this block of code in a try/catch. I am not a scala programmer, so this may not be the best implementation. However, if we do not contain regex errors related to prefix processing, the error bubbles up causing parsing to exit with an error, and the database/index is unusable. Therefore, I feel like its worthwhile to trap the error here, and just skip over processing errors. Submitting this for consideration/feedback. Perhaps it would be even better to trap the specific error identified in Issue #53, rather than trapping all errors.