search

foursquare / fsqio

A monorepo that holds all of Foursquare's opensource projects
Apache License 2.0
252 stars 54 forks source link

Add joda LocalDate to enhanced_types #57

Closed omrihq closed 5 years ago

omrihq commented 5 years ago

Updated

mateor commented 5 years ago

Okay, thanks for the contributions! This has been approved, so let me briefly outline the process. (obviously, this goes for both of your PRS).

Fsq.io is built by splitting the code directly from our internal monorepo. So we don't land PRs directly through Github, but instead land contributions directly to our codebase (preserving the original author credits, of course). The patches then are deployed to Fsq.io in the next update.

We will get that cycle started and I will circle back here and "close" the PR when your patch is pushed to Fsq.io.

Thanks again for upstreaming the code :)

mateor commented 5 years ago

I neglected to update this PR - but we landed your change (with your author credit) and it was deployed to Fsq.io last month. Thanks for submitting the patch!

5a49d5b1b230c42131669b22183efaad48a911ec