search

foursquare / fsqio

A monorepo that holds all of Foursquare's opensource projects
Apache License 2.0
252 stars 54 forks source link

Make PrimitiveRenderTypes correctly output long values with tests #58

Closed omrihq closed 5 years ago

omrihq commented 5 years ago

This addresses https://github.com/foursquare/fsqio/issues/45

iantabolt commented 5 years ago

Thanks for this! Can you add a test? I think it would go in test/thrift/io/fsq/spindle/codegen/runtime/constants/test/gen/constantine.thrift and test/jvm/io/fsq/spindle/codegen/runtime/test/ScalaConstTest.scala.

omrihq commented 5 years ago

Good catch, updated

mateor commented 5 years ago

Patch was accepted and is live in Fsq.io. Thank you!

fa5c61a688d2c59d496e639726ba5b4d472307f6