foursquare / qgis-plugin

Foursquare Studio plugin for QGIS
https://plugins.qgis.org/plugins/Unfolded/
GNU General Public License v2.0
19 stars 4 forks source link

Fix QGIS 3.20 support #58

Closed Joonalai closed 3 years ago

Joonalai commented 3 years ago

This PR:

Resolves #57.

codecov-commenter commented 3 years ago

Codecov Report

Merging #58 (56b0f9f) into main (04d36c1) will decrease coverage by 16.36%. The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
- Coverage   92.97%   76.61%   -16.37%     
===========================================
  Files          20       28        +8     
  Lines        2363     2531      +168     
===========================================
- Hits         2197     1939      -258     
- Misses        166      592      +426     
Flag Coverage Δ
unittests 76.61% <87.50%> (-16.37%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Unfolded/core/processing/layer2dataset.py 94.81% <75.00%> (-0.68%) :arrow_down:
Unfolded/test/conftest.py 94.16% <100.00%> (+0.04%) :arrow_up:
Unfolded/test/test_layer2dataset.py 100.00% <100.00%> (ø)
Unfolded/core/__init__.py
Unfolded/ui/settings_panel.py 0.00% <0.00%> (ø)
Unfolded/definitions/gui.py 0.00% <0.00%> (ø)
Unfolded/plugin.py 0.00% <0.00%> (ø)
Unfolded/ui/about_panel.py 0.00% <0.00%> (ø)
Unfolded/ui/base_panel.py 0.00% <0.00%> (ø)
Unfolded/ui/export_panel.py 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04d36c1...56b0f9f. Read the comment docs.

Joonalai commented 3 years ago

The coverage didn't actually drop, it was just calculated only on test files previously.