search

fourthline / mmlTools

MabiIcco - マビノギ用MMLエディタ (MML editor for Mabinogi)
https://fourthline.jp/mabiicco/
50 stars 19 forks source link

Optimiation is not optimal #79

Closed kernighan closed 2 years ago

kernighan commented 2 years ago

Imported a MIDI, the resulting track has:

'r1r2r8.'

Optimization should have at least reduced this to:

'r1.r8.'

kernighan commented 2 years ago

I suspect that the optimizer is treating rests the same way as notes. I.e., it treats "r1r2" the same as "c1c2" but they should be handled differently since rests can be combined in an optimal fashion.

fourthline commented 2 years ago

https://github.com/fourthline/mmlTools/commit/446df44b3d089d30a80326622f44d1ef89db913d Before:

After:

etc...

fourthline commented 2 years ago

Released in v1.2.80