Search Functionality Crippled

fow5040 / Wox.Plugin.SpotifyPremium

Forked from JohnTheGr8's Spotify plugin - uses the new Web API and requires Premium

MIT License

9 stars 6 forks source link

Search Functionality Crippled #4

Closed Iaotle closed 3 years ago

Iaotle commented 4 years ago

Issue Description

The search function often returns no results whatsoever. Have tried using both the provided and the private Client ID / Secret ID.

Functionality Affected

[ ] Controlling the local Spotify client (changing track, pausing, skipping, muting)
[x] Searching Spotify for albums, artists or songs

Software Versions

Spotify client version 1.1.36.734.g8731c306
Wox version 1.4.1196

fow5040 commented 4 years ago

Hey @Iaotle - I finally got around to fixing this and it looks like any URI with no artwork in Spotify (in this case, the Artist "Iron Mango"...) was throwing an exception. I modified my code to return a generic icon if artwork is missing. I'll merge the fix into master and re-release soon.

Also - would be happy to merge your .NET Core 3.1 changes to my plugin if it has been working fine for you.

Cheers

Iaotle commented 3 years ago

@fow5040 not sure what you mean about the .NET stuff. Plans to re-release anytime soon?

fow5040 commented 3 years ago

@Iaotle Hey this is a bit late - I merged the small error handling fix to master so spotify artists with missing artwork (in this case, "Iron Mango") do not break the plugin.

I can do a quick re-release now, but I plan to do a bigger rework with the updated SpotifyAPI.Web 6.2.0 Nuget package that enables queue management, among other things.

fow5040 commented 3 years ago

Mislabeled the fix - 23dd81b9efbda6405e6df1851b40ee23d1f2dd29 solves this issue, not Issue #5

Iaotle commented 3 years ago

Cheers! Everything works! <3