fowode / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

Hint and Spy mode default on/off option #745

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I found it frustrating to have to manually turn off the Hint and Spy modes 
everytime I started a new local game. I added options in the preferences menu 
to have these on or off by default. Requested fix is at:

https://code.google.com/r/dmalmer-pychess/source/detail?r=7803a922bb63a6d260137e
fe33750fb21ff824af

Let me know if you think anything should be different. The list in the "General 
Display Options" is starting to get a little long, but it looks alright still. 
We might want to think about reorganizing the preference menus if a few more 
options get added.

Original issue reported on code.google.com by dmalmer on 2 Jan 2013 at 2:01

GoogleCodeExporter commented 9 years ago
Maybe we should handle this similar to "View/Show Sidepanels". It has no option 
in preferences, just in the View menu. I don't know if this inconsistency is 
good or bad though.

Thomas, Matt, others?

Original comment by gbtami on 3 Jan 2013 at 9:47

GoogleCodeExporter commented 9 years ago
Why not just have pychess remember whether Hint and Spy mode were checked from 
the last game?

Original comment by mattgatto on 4 Jan 2013 at 12:39

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 2b974f8c9635.

Original comment by gbtami on 7 Jan 2013 at 11:39

GoogleCodeExporter commented 9 years ago
dmalmer, applied your patch without the new preferences option part. Thx!

Original comment by gbtami on 7 Jan 2013 at 11:42

GoogleCodeExporter commented 9 years ago
Thanks! Leaving the options out of the preferences menu definitely makes more 
sense.

Original comment by dmalmer on 7 Jan 2013 at 7:15