fowode / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

Game end notification bar text not readable #780

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. End a game

What is the expected output? What do you see instead?
The text in the info box isn't readable because the background is dark and the 
foreground text is black. A screenshot is attached. The InfoBar.py stuff used 
in the FICS lounge still shows up correctly. This is on Fedora 18.

Did you use PyChess from a repo, tarball, install or hg?
hg

Original issue reported on code.google.com by mattgatto on 6 Jul 2013 at 8:38

Attachments:

GoogleCodeExporter commented 9 years ago
The FICS connection dialog needs to be fixed too.

Original comment by mattgatto on 19 Jul 2013 at 8:32

Attachments:

GoogleCodeExporter commented 9 years ago
Issue 789 has been merged into this issue.

Original comment by gbtami on 20 Jul 2013 at 9:50

GoogleCodeExporter commented 9 years ago
A preliminary patch which fixes the FICS logon error messages, but not the 
gamewidget stuff is attached. The gamewidget game-end fix is slightly more 
complicated and probably should use the full widgets/InfoBar.py stuff rather 
than just gtk.InfoBar since there might be multiple messages a user has to 
respond to in a game, especially during FICS games. My glade editor (3.14.2) 
seems to want to convert glades I edit to "<!-- interface-requires gtk+ 3.0 
-->", hopefully that will work with the other 2.X glades?

Original comment by mattgatto on 20 Jul 2013 at 2:02

Attachments:

GoogleCodeExporter commented 9 years ago
And speaking of widgets/InfoBar.py, one change I'd like to make in it, would be 
for new messages in the stack to not overlay old ones, but instead appear next 
to them, packed horizontally. This is especially useful for challenges and 
manual seek acceptances, since if the user has multiple offers, they probably 
would like to see all of them at the same time before deciding which one to 
choose.

Original comment by mattgatto on 20 Jul 2013 at 2:15

GoogleCodeExporter commented 9 years ago
The "<!-- interface-requires gtk+ 3.0 -->" message suggests me that you use 
something supported from gtk+ 3.0. Can you commit this patch in a temp clone 
instead please? That way I can try this on my old Linux box, not containing any 
gtk3 stuff.

Original comment by gbtami on 20 Jul 2013 at 3:36

GoogleCodeExporter commented 9 years ago
Forget my #5 comment. No problem with glade 3.8.x and gtk 2.24.x here, so 
committed your patch.

Original comment by gbtami on 24 Jul 2013 at 7:32

GoogleCodeExporter commented 9 years ago
This issue was closed by revision ed69f0f3c438.

Original comment by mattgatto on 27 Jul 2013 at 4:16