Sometimes observed FICS game end not detected

fowode / pychess

Automatically exported from code.google.com/p/pychess

GNU General Public License v3.0

0 stars 0 forks source link

Sometimes observed FICS game end not detected #790

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Observe a game on FICS.
It ends for some reason, but PyChess not reflects to this. Clock runs, etc.

Original issue reported on code.google.com by gbtami on 20 Jul 2013 at 11:28

Attachments:

game-end-not-detected.png

GoogleCodeExporter commented 9 years ago

This issue was closed by revision a562686b9b46.

Original comment by mattgatto on 26 Jul 2013 at 12:42

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

I guess that what was happening was that sometimes 
BoardManager.onUnobserveGame() was executing before BoardManager.onGameEnd() 
and deleting self.gamemodelStartedEvents[gameno] so that onGameEnd() didn't 
follow the right code path. Fixed in revision a562686b9b46

Original comment by mattgatto on 26 Jul 2013 at 12:46

GoogleCodeExporter commented 9 years ago

Good job, works good. No more hours to standby for a next move that never 
happen!

Original comment by yoanntar on 26 Jul 2013 at 5:26