fowode / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

players' rating and status changes not being processed after their games end #795

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
the <wa ...> availability notices in HelperConnection only work for when a 
player connects and i think when a player manually makes himself 
available/unavailable/etc.

i tried messing around with pin/gin/availinfo for HelperConnection in 
FICSConnection._connect() but I still couldn't get it to output these types of 
messages after the respective players in a game has their game end:

09:12:01
------------------------------------------------------------
khakimenez Blitz (1196), Std (1424), Wild (----), Light(----), Bug(----)
is now available for matches.
BocaJuniors(U) Blitz (++++), Std (++++), Wild (++++), Light(++++), Bug(++++)
is now available for matches.
09:12:11

For some reason I don't yet understand, I could only get them to appear as in 
the attached patch which parses the messages from the normal (non-helper) 
connection.

Original issue reported on code.google.com by mattgatto on 26 Jul 2013 at 4:17

Attachments:

GoogleCodeExporter commented 9 years ago
It's not that the message regexps are wrong; it's simply that, without the 
patch, these vital status/rating updates simply aren't sent by the server. 
They're very important for not only the player list; functions like 
AdjournedTabSection._update_infobarmessagebutton_sensitivity() rely on getting 
accurate status updates for setting their sensitivities correctly for buttons 
like "Request Continuation".

Original comment by mattgatto on 26 Jul 2013 at 4:25

GoogleCodeExporter commented 9 years ago
If anyone can figure out how to get helperconnection to do this, that would be 
cool.

Original comment by mattgatto on 26 Jul 2013 at 4:27

GoogleCodeExporter commented 9 years ago
This issue was closed by revision b3070f1134cb.

Original comment by gbtami on 26 Jul 2013 at 8:57