search

fowode / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

Make "Actions" -> "Offer *" insensitive when there is an outstanding offer for the respective action menu item #797

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Make any type of offer from the Actions menu, "Offer Draw" for example

What is the expected output? What do you see instead?
The "Offer Draw" menu item should be made insensitive until it gets declined 
(which should happen
automatically -- and does during FICS games -- if the opponent moves without 
responding to the offer). Same goes with abort, adjourn, pause, resume and 
undo. They should all be insensitive while there is already an outstanding 
offer of that type.

Original issue reported on code.google.com by mattgatto on 28 Jul 2013 at 3:50

GoogleCodeExporter commented 9 years ago 
When the message system is in place, we could have an infobar message like
"You sent a draw offer."                               [Withdraw Offer]
or
"Awaiting response to your draw offer..."          [Withdraw Offer]

Original comment by mattgatto on 28 Jul 2013 at 6:29

GoogleCodeExporter commented 9 years ago 
To simply things for now... instead of adding closed/dismissed offers to a 
"Messages" sidepanel, we can just change Actions -> Offer Draw, or whatever the 
offer is, to Actions -> Accept Draw Offer. Similarly, after offering a draw, 
Actions -> Offer Draw can be changed to Actions -> Withdraw Draw Offer.

Original comment by mattgatto on 14 Dec 2013 at 9:03

GoogleCodeExporter commented 9 years ago 
Closely related: for FICS games, "Offer Pause" shouldn't be sensitive until 2 
moves made and clocks started (sending pause offer on FICS gives error reply 
before clocks started).

Original comment by mattgatto on 14 Dec 2013 at 9:05

GoogleCodeExporter commented 9 years ago 
I took care of comment 3 in revision 08011081a9c9.

Original comment by mattgatto on 14 Dec 2013 at 11:04

GoogleCodeExporter commented 9 years ago 
Apparently you can't withdraw a draw offer, so that particular offer would be 
insensitive after making a draw offer. But Adjourn, Abort, Pause, Resume, and 
Undo would all change to "Withdraw [offer type]".

Original comment by mattgatto on 14 Dec 2013 at 11:48