search

fowode / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
0 stars 0 forks source link

crash upon double-clicking a variation in Hint panel #839

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I was observing a FICS game and I arrowed back a few moves to examine a certain 
position then went back to the end of the game (i think) and double-clicked a 
variation in the Hint panel to insert it into the annotation panel.

Traceback (most recent call last):
  File "/home/gatto/code/hg/pychess/sidepanel/bookPanel.py", line 568, in row_activated
    self.advisors[path[0]].row_activated(iter, self.boardview.model)
  File "/home/gatto/code/hg/pychess/sidepanel/bookPanel.py", line 259, in row_activated
    model.add_variation(self.engine.board, moves)
  File "/home/gatto/code/hg/pychess/lib/pychess/Utils/GameModel.py", line 790, in add_variation
    new = board.move(move)
  File "/home/gatto/code/hg/pychess/lib/pychess/Utils/Board.py", line 238, in move
    assert self[move.cord0], "%s %s" % (move, self.asFen())
AssertionError: d3e3 6k1/3q1pp1/Qp5p/3p1B2/3Pnb2/1P6/P1R2PP1/6K1 b - - 4 35

Original issue reported on code.google.com by mattgatto on 21 Feb 2014 at 7:58

Attachments:

GoogleCodeExporter commented 9 years ago 
Can't reproduce this. Matt, is this with latest source? Line #790 in 
GameModel.py is an empty line here!

Original comment by gbtami on 21 Feb 2014 at 6:46

GoogleCodeExporter commented 9 years ago 
Yeah, I was probably running with revision 
4defa7e063284a67ba9b2baf5078d2bf12484c69 applied before I'd committed it.

Original comment by mattgatto on 21 Feb 2014 at 10:36

GoogleCodeExporter commented 9 years ago 
You produced this with rev. 643554dce2f5 as the .log first line reports, but 
this rev seems not exist in the repo at all.
I think this bug was fixed by 
http://code.google.com/p/pychess/source/detail?r=50920235f07c3f400f73af16d8defb5
7011317db
http://code.google.com/p/pychess/source/detail?r=50920235f07c3f400f73af16d8defb5
7011317db

Original comment by gbtami on 22 Feb 2014 at 10:53

GoogleCodeExporter commented 9 years ago 
I'm usually testing out various patches in my mq (mercurial queue) and I don't 
remember what patches were on my tip at the time of the crash. I'm sure I was 
running from up to date hg though and I'm pretty sure that none of the patches 
I'd have been testing overlap with revision 4defa7e06328 or any other related 
code.

Original comment by mattgatto on 23 Feb 2014 at 11:30

GoogleCodeExporter commented 9 years ago 
In my last comment I meant revision 50920235f07c, not 4de*.

Original comment by mattgatto on 23 Feb 2014 at 11:32

GoogleCodeExporter commented 9 years ago 
Matt, can you reproduce this?

Original comment by gbtami on 12 Mar 2014 at 10:13

GoogleCodeExporter commented 9 years ago 
No I can't.

Original comment by mattgatto on 12 Mar 2014 at 10:16

GoogleCodeExporter commented 9 years ago 
Thx. I think it was fixed.

Original comment by gbtami on 12 Mar 2014 at 10:20