board not editable/variation adding disabled in local engine vs. local engine games

[GoogleCodeExporter]

What steps will reproduce the problem?
1. observe a local engine vs. engine game

What is the expected output? What do you see instead?
You should be able to go to browse to any move via back/forward buttons and 
move pieces to add variations, but you can't. 

Original issue reported on code.google.com by mattgatto on 26 Apr 2014 at 11:13

[GoogleCodeExporter]

A patch to fix this is attached. Is there a reason to keep around a variable 
controlling whether pre-move is on? Certainly there is not for the case of 
engine vs. engine games since engines don't move the pieces on the board to 
make moves :). I can see a justification in that it might confuse novice users, 
but in that case we might want to handle it by: a) keeping track of the first 
time the user makes a pre-move, b) popping up a help or infobar message the 
first time a user makes a pre-move explaining what pre-move is, and asking 
whether they want to continue keeping it enabled. Which is alot of work for 
little benefit, so I think we should just disable it for now.

Original comment by mattgatto on 27 Apr 2014 at 2:56

Attachments:

• issue-856.patch

[GoogleCodeExporter]

I can browse moves in engine-engine games and can add variations. Maybe I 
misunderstand something.

Original comment by gbtami on 28 Apr 2014 at 9:01

[GoogleCodeExporter]

It's when an (engine-engine) game is finished that variation adding/board 
editing is disabled. It works while the game is still ongoing. And I just 
realized the patch I attached in my comment #1 doesn't fix that.

Original comment by mattgatto on 28 Apr 2014 at 12:42

[GoogleCodeExporter]

This issue was closed by revision 0745999032cc.

Original comment by gbtami on 28 Apr 2014 at 9:01

• Changed state: Fixed