need notifications for when one's formula prevents issuing and receiving challenges

fowode / pychess

Automatically exported from code.google.com/p/pychess

GNU General Public License v3.0

0 stars 0 forks source link

need notifications for when one's formula prevents issuing and receiving challenges #907

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

We need notifications that give people the ability to accept, let through, or 
re-issue challenges that are ignored because of formula mismatches as seen 
below.

On the receiving side:

07:40:57 ('mgatto', 'raw') DEBUG: 
Ignoring (formula): gbtami (1509) mgatto (1449) rated lightning 1 0.
fics% 
07:40:57 ('mgatto', 'lines') DEBUG: 
07:40:57 ('mgatto', 'lines') DEBUG: Ignoring (formula): gbtami (1509) mgatto 
(1449) rated lightning 1 0.

On the issuing side:

23:56:17 ('mgatto', 'raw') DEBUG: ^U123^V73^VMatch request does not fit formula 
for blik:
blik's formula: f1 & f2 & f3 & f4 & f5 & (rd<80) & !computer

f1=1: 2<=time                      # Don't play Space Invaders on the board
f2=1: inc<=10 & time<=10           # And don't spend hours on a move
f3=0: rated & 1<=assesswin         # No chicken please
f4=1: blitz | lightning            # Chess is chess is chess...
f5=0: !abuser & !private & nocolor # It's a noble game
^W

Original issue reported on code.google.com by mattgatto on 20 Aug 2014 at 6:58

GoogleCodeExporter commented 9 years ago

Original comment by mattgatto on 20 Aug 2014 at 7:01

Changed title: need notifications for when one's formula prevents issuing and receiving challenges

GoogleCodeExporter commented 9 years ago

Original comment by gbtami on 24 Aug 2014 at 8:26

Added labels: Priority-High

GoogleCodeExporter commented 9 years ago

It would be alot of work to give the issuing player the ability to 
automatically change their variables/formula such that the challenge can go 
through as it would involved manually parsing both the challenger and 
challengee's formulas and variables and figuring it out manually. The server 
doesn't try and help us out either.

We should still have a GUI notification though.

Original comment by mattgatto on 24 Aug 2014 at 8:57

GoogleCodeExporter commented 9 years ago

Agreed. The GUI notification is enough for now.

Original comment by gbtami on 24 Aug 2014 at 9:16

GoogleCodeExporter commented 9 years ago

This issue was closed by revision cdd0bdfd9b37.

Original comment by gbtami on 22 Sep 2014 at 10:56

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Though my commit works on ignored rematch offers, it would be good to send 
similar notification when the match offer was sent from player list tab too.
Maybe the board manager is not the best place to handle this signal too.

Original comment by gbtami on 22 Sep 2014 at 2:58

Changed state: Reopened

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 132f5bfd3044.

Original comment by gbtami on 22 Sep 2014 at 9:35

Changed state: Fixed