search

fox-it / dissect.cobaltstrike

Python library for dissecting and parsing Cobalt Strike related data such as Beacon payloads and Malleable C2 Profiles
https://dissect-cobaltstrike.readthedocs.io
MIT License
147 stars 21 forks source link

Decode SETTING_DOMAINS using latin-1 instead of ascii codec #45

Closed yunzheng closed 1 year ago

yunzheng commented 1 year ago

This correctly parses beacons that have a unicode character in the domain name. Before the unicode character would've been ignored due to ascii codec and ignoring invalid ascii characters.

codecov[bot] commented 1 year ago

Codecov Report

Merging #45 (d52a527) into main (e579b1d) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files          11       11           
  Lines        2524     2524           
=======================================
  Hits         1891     1891           
  Misses        633      633
Flag Coverage Δ
unittests 74.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/cobaltstrike/beacon.py 93.61% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more