search

fox-it / dissect.evidence

A Dissect module implementing a parsers for various forensic evidence file containers, currently: AD1, ASDF and EWF.
GNU Affero General Public License v3.0
7 stars 2 forks source link

Add ASDF file recovery #8

Closed Schamper closed 1 year ago

Schamper commented 2 years ago

(DIS-1630)

Schamper commented 2 years ago

Depends on #7

codecov[bot] commented 2 years ago

Codecov Report

Merging #8 (14def2f) into main (6fabb25) will decrease coverage by 2.55%. The diff coverage is 36.47%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   65.24%   62.69%   -2.56%     
==========================================
  Files          10       11       +1     
  Lines         892      973      +81     
==========================================
+ Hits          582      610      +28     
- Misses        310      363      +53
Flag Coverage Δ
unittests 62.69% <36.47%> (-2.56%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/evidence/tools/asdf/repair.py 0.00% <0.00%> (ø)
dissect/evidence/asdf/asdf.py 90.65% <93.93%> (+0.65%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Miauwkeru commented 2 years ago

I noticed that I put some review comments of #7 here, is there a method to tell the github pr to target another branch?

Schamper commented 2 years ago

I noticed that I put some review comments of #7 here, is there a method to tell the github pr to target another branch?

Yes but I'll leave it like this because I think I'll lose your comments otherwise. I'll put each change in the correct MR.