search

fox-it / dissect.target

The Dissect module tying all other Dissect modules together. It provides a programming API and command line tools which allow easy access to various data sources inside disk images or file collections (a.k.a. targets).
GNU Affero General Public License v3.0
38 stars 42 forks source link

Fix gzip trailer_offset calculation in FortiFirmwareFile #657

Closed yunzheng closed 3 months ago

yunzheng commented 3 months ago

Also added a regression test

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.85%. Comparing base (8397141) to head (9a36644).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #657 +/- ## ========================================== + Coverage 74.83% 74.85% +0.01% ========================================== Files 288 288 Lines 24024 24023 -1 ========================================== + Hits 17978 17982 +4 + Misses 6046 6041 -5 ``` | [Flag](https://app.codecov.io/gh/fox-it/dissect.target/pull/657/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/dissect.target/pull/657/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `74.85% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.