search

fox-it / dissect.target

The Dissect module tying all other Dissect modules together. It provides a programming API and command line tools which allow easy access to various data sources inside disk images or file collections (a.k.a. targets).
GNU Affero General Public License v3.0
44 stars 44 forks source link

Add prefetch to MQTT loader #659

Closed cecinestpasunepipe closed 5 months ago

cecinestpasunepipe commented 6 months ago

(DIS-3094)

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 74.99%. Comparing base (bdd4426) to head (94fd42f).

Files Patch % Lines
dissect/target/loaders/mqtt.py 82.35% 6 Missing :warning:
dissect/target/tools/query.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #659 +/- ## ========================================== + Coverage 74.97% 74.99% +0.01% ========================================== Files 288 288 Lines 24172 24192 +20 ========================================== + Hits 18124 18143 +19 - Misses 6048 6049 +1 ``` | [Flag](https://app.codecov.io/gh/fox-it/dissect.target/pull/659/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/dissect.target/pull/659/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `74.99% <80.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Miauwkeru commented 5 months ago

Acked, but do add the from __future__ import annotations to the start of the test file