search

fox-it / dissect.target

The Dissect module tying all other Dissect modules together. It provides a programming API and command line tools which allow easy access to various data sources inside disk images or file collections (a.k.a. targets).
GNU Affero General Public License v3.0
43 stars 44 forks source link

Correctly detect Windows 11 builds #714

Closed JSCU-CNI closed 3 months ago

JSCU-CNI commented 4 months ago

This PR adds correct version detection for Windows 11 systems.

This is our 100th dissect PR :tada:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.92%. Comparing base (c23a1eb) to head (f15c801).

Files Patch % Lines
dissect/target/plugins/os/windows/_os.py 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #714 +/- ## ========================================== - Coverage 74.92% 74.92% -0.01% ========================================== Files 295 295 Lines 25065 25070 +5 ========================================== + Hits 18781 18784 +3 - Misses 6284 6286 +2 ``` | [Flag](https://app.codecov.io/gh/fox-it/dissect.target/pull/714/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/dissect.target/pull/714/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `74.92% <75.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.