fox-it / flow.record

Recordization library
GNU Affero General Public License v3.0
7 stars 9 forks source link

Add AttributeError to except ImportError statements #106

Closed Miauwkeru closed 7 months ago

Miauwkeru commented 7 months ago

In some cases windows throws an AttributeError instead of an ImportError during an import

codecov[bot] commented 7 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (09ed812) 80.20% compared to head (f2c229d) 79.57%. Report is 1 commits behind head on main.

Files Patch % Lines
flow/record/base.py 0.00% 4 Missing :warning:
flow/record/fieldtypes/__init__.py 0.00% 2 Missing :warning:
flow/record/tools/rdump.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #106 +/- ## ========================================== - Coverage 80.20% 79.57% -0.63% ========================================== Files 33 33 Lines 3132 3129 -3 ========================================== - Hits 2512 2490 -22 - Misses 620 639 +19 ``` | [Flag](https://app.codecov.io/gh/fox-it/flow.record/pull/106/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/flow.record/pull/106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `79.57% <11.11%> (-0.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Miauwkeru commented 7 months ago

went for a different solution