fox-it / flow.record

Recordization library
GNU Affero General Public License v3.0
7 stars 9 forks source link

Fix hashing of records with list fieldtypes #116

Closed JSCU-CNI closed 4 months ago

JSCU-CNI commented 5 months ago

Currently flow.record breaks when __hash__ is called on a record that has a list fieldtype. As lists are mutable, they have to be converted into tuples first so they can be hashed.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.54%. Comparing base (5b9e62a) to head (619f40c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #116 +/- ## ========================================== + Coverage 80.51% 80.54% +0.02% ========================================== Files 34 34 Lines 3182 3197 +15 ========================================== + Hits 2562 2575 +13 - Misses 620 622 +2 ``` | [Flag](https://app.codecov.io/gh/fox-it/flow.record/pull/116/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/flow.record/pull/116/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `80.54% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.