Closed cecinestpasunepipe closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.73%. Comparing base (
4a47670
) to head (c8a46a1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Do you have any examples where this is an issue and is considered a bug? Maybe in most cases if you encounter an empty string as a path value, setting the record value to
None
would be better.
There can be cases where we parse some artefact which may or may not have a path field. IMO there's a difference between the absence of the path field (None
) or an empty path field (""
) and thus it should be possible to be noted as such in the record.
My take on this issue: https://github.com/fox-it/flow.record/pull/122
As this is a totally different way to tackle this problem from this PR i've created a new branch and PR.
My take on this issue: #122
As this is a totally different way to tackle this problem from this PR i've created a new branch and PR.
I added some comments to your PR. I like your solution and I was thinking along the same lines, however like I pointed out in my other comment, it does not seem to meet the requested requirements.
I left a comment in the first unresolved thread with my point of view, my other suggestions are still unresolved. If you want me to review anything else let me know.
After some discussion, this PR is closed in favour of https://github.com/fox-it/flow.record/pull/122
(DIS-2557)