search

fox-it / flow.record

Recordization library
GNU Affero General Public License v3.0
7 stars 9 forks source link

Use non-dev dependencies in pyproject.toml #124

Closed narimantos closed 3 months ago

narimantos commented 3 months ago

https://github.com/fox-it/dissect/issues/61

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.61%. Comparing base (a8fd59d) to head (e3cd4ed).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #124 +/- ## ========================================== + Coverage 83.76% 84.61% +0.84% ========================================== Files 34 34 Lines 3413 3413 ========================================== + Hits 2859 2888 +29 + Misses 554 525 -29 ``` | [Flag](https://app.codecov.io/gh/fox-it/flow.record/pull/124/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/flow.record/pull/124/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `84.61% <ø> (+0.84%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

narimantos commented 3 months ago

We decided to drop this PR because flow.record doesn't have any Dissect dependencies. With the --pre command we also get dev versions of (sub)dependencies that we don't want dev versions from.