search

fox-it / flow.record

Recordization library
GNU Affero General Public License v3.0
7 stars 9 forks source link

rdump csv output has empty CR LF lines #42

Closed hozoin closed 1 year ago

hozoin commented 1 year ago

Both rdump <input file> -w csvfile://<output file> and rdump <input file> -C > <output file> create csv file in which every line ends with CR followed by CR LF. As CR ends line, result is that every second line of csv file is empty line containing only CR LF.

I am using Python 3.9.5 and Windows 10.

yunzheng commented 1 year ago

This looks like this issue https://github.com/python/cpython/issues/51447

I think opening the csv file with newline="" will fix the issue, will look into it and do some tests

hozoin commented 1 year ago

Yes, newline must be specified. https://docs.python.org/3/library/csv.html#id3

yunzheng commented 1 year ago

Should be fixed, new build should land on PyPi shortly.