fox-it / flow.record

Recordization library
GNU Affero General Public License v3.0
7 stars 9 forks source link

Remove sed from windows test workflow #82

Closed yunzheng closed 1 year ago

Schamper commented 1 year ago

@pyrco IIRC this sed was only important for publishing to PyPI to get rid of the commit hashes, right? So it should be fine to remove it from these tests?

codecov[bot] commented 1 year ago

Codecov Report

Merging #82 (5442cd1) into main (8a1c74f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   79.16%   79.16%           
=======================================
  Files          32       32           
  Lines        2894     2894           
=======================================
  Hits         2291     2291           
  Misses        603      603           
Flag Coverage Δ
unittests 79.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pyrco commented 1 year ago

@pyrco IIRC this sed was only important for publishing to PyPI to get rid of the commit hashes, right? So it should be fine to remove it from these tests?

yes