fox-it / flow.record

Recordization library
GNU Affero General Public License v3.0
7 stars 9 forks source link

Add DuckDB adapter #97

Closed yunzheng closed 6 months ago

yunzheng commented 9 months ago

This adds DuckDB reader and writer support. Because DuckDB is mostly compatible with the SQLite API, we just subclass from the existing SQLite adapter with minimal changes.

Changes done to the SQLite adapter and tests are:

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (09ed812) 80.20% compared to head (aa840a8) 80.41%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== + Coverage 80.20% 80.41% +0.21% ========================================== Files 33 34 +1 Lines 3132 3166 +34 ========================================== + Hits 2512 2546 +34 Misses 620 620 ``` | [Flag](https://app.codecov.io/gh/fox-it/flow.record/pull/97/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/fox-it/flow.record/pull/97/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it) | `80.41% <100.00%> (+0.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fox-it#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yunzheng commented 8 months ago

DuckDB test is excluded for now on Python 3.12 as there are no wheels yet. When they are wheels available it can be re-added in the tests.

yunzheng commented 8 months ago

It looks like codecov uses Python 3.12 for the coverage tests and on Python 3.12 I skip the duckdb tests, not sure where I can check that.

yunzheng commented 6 months ago

@Schamper New duckdb release seems to have fixed the codecov tests.