search

foxBMS / foxbms-2

foxBMS 2, online documentation at https://docs.foxbms.org
https://foxbms.org
Other
263 stars 121 forks source link

Wrong value set in fram.c at line 127 #26

Closed God-of-platypus closed 1 month ago

God-of-platypus commented 10 months ago

When there is an error with FRAM_WriteData function in the function FRAM_ReinitializeAllEntries, the variable ret_val is set to STD_OK. The value should be STD_NOT_OK.

https://github.com/foxBMS/foxbms-2/blob/06d3878f26d05e3a7fc42e64af821664eb309e13/src/app/driver/fram/fram.c#L127

foxBMS commented 10 months ago

Dear @God-of-platypus,

Thanks for the report. Yes this is a bug. We will fix this in the next release.

Best regards, The foxBMS Team

foxBMS commented 1 month ago

Hi @God-of-platypus,

The issue has been fixed in foxBMS 2 v1.7.0.

Thanks for the hint!

Best regards, The foxBMS Team