foxcpp / maddy

✉️ Composable all-in-one mail server.
https://maddy.email
GNU General Public License v3.0
5.01k stars 241 forks source link

IMAP IDLE capability missing (Push support) #446

Closed Dr-Escher closed 2 years ago

Dr-Escher commented 2 years ago

Describe the bug

Latest maddy doesn't report the IMAP IDLE capability, rendering message pushing unavailable.

Steps to reproduce

Log files

  1. maddy instance [Parent 11216: IMAP]: I/IMAP 7f63b185f800:redacted:NA:CreateNewLineFromSocket: 45 OK [CAPABILITY IMAP4rev1 LITERAL+ SASL-IR CHILDREN UNSELECT MOVE APPENDLIMIT APPENDLIMIT CHILDREN I18NLEVEL=1 SORT THREAD=ORDEREDSUBJECT COMPRESS NAMESPACE] AUTHENTICATE completed

Other examples for reference:

  1. generic provider A [Parent 11216: IMAP]: I/IMAP 7f63bdbea000:redacted:NA:CreateNewLineFromSocket: 93 OK [CAPABILITY IMAP4rev1 LITERAL+ SASL-IR LOGIN-REFERRALS ID ENABLE IDLE SORT SORT=DISPLAY THREAD=REFERENCES THREAD=REFS THREAD=ORDEREDSUBJECT MULTIAPPEND URL-PARTIAL CATENATE UNSELECT CHILDREN NAMESPACE UIDPLUS LIST-EXTENDED I18NLEVEL=1 CONDSTORE QRESYNC ESEARCH ESORT SEARCHRES WITHIN CONTEXT=SEARCH LIST-STATUS BINARY MOVE SPECIAL-USE QUOTA] Logged in

  2. generic provider B [Parent 11216: IMAP]: I/IMAP 7f63b1877000:redacted:A:CreateNewLineFromSocket: * CAPABILITY IMAP4rev1 CHILDREN ENABLE ID IDLE LIST-EXTENDED LIST-STATUS LITERAL- MOVE NAMESPACE SASL-IR SORT SPECIAL-USE THREAD=ORDEREDSUBJECT UIDPLUS UNSELECT WITHIN APPENDLIMIT=29360128

  3. generic provider C [Parent 11216: IMAP]: I/IMAP 7f63b1869800:redacted:NA:CreateNewLineFromSocket: 61 OK [CAPABILITY IMAP4rev1 SASL-IR LOGIN-REFERRALS ID ENABLE IDLE SORT SORT=DISPLAY THREAD=REFERENCES THREAD=REFS THREAD=ORDEREDSUBJECT MULTIAPPEND URL-PARTIAL CATENATE UNSELECT CHILDREN NAMESPACE UIDPLUS LIST-EXTENDED I18NLEVEL=1 CONDSTORE QRESYNC ESEARCH ESORT SEARCHRES WITHIN CONTEXT=SEARCH LIST-STATUS BINARY MOVE SNIPPET=FUZZY PREVIEW=FUZZY XLIST LITERAL+ NOTIFY SPECIAL-USE] Logged in

Configuration file

Default configuration except $(hostname) and $(primary_domain) https://github.com/foxcpp/maddy/blob/59727496a949a38ba6d8a9ab1d3aacc086689165/maddy.conf#L1

Environment information

foxcpp commented 2 years ago

That seems to be the regression in go-imap 1.2. Ref. https://github.com/emersion/go-imap/pull/453

Dr-Escher commented 2 years ago

Confirmed to be fixed in go-imap v1.2.1