search

foxcpp / maddy

✉️ Composable all-in-one mail server.
https://maddy.email
GNU General Public License v3.0
5k stars 240 forks source link

fix goroutine "leak" in openmetrics #519

Closed biancalana closed 2 years ago

biancalana commented 2 years ago

make graceful shutdown when openmetrics endpoint is enable

foxcpp commented 2 years ago

Thanks!

codecov-commenter commented 2 years ago

Codecov Report

Merging #519 (226ea82) into master (fd8260c) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
- Coverage   52.90%   52.89%   -0.01%     
==========================================
  Files         126      126              
  Lines       12930    12931       +1     
==========================================
  Hits         6840     6840              
- Misses       5452     5453       +1     
  Partials      638      638
Flag Coverage Δ
integration 34.09% <0.00%> (-0.01%) :arrow_down:
unit 54.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/endpoint/openmetrics/om.go 4.16% <0.00%> (-0.09%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.