foxcpp / maddy

✉️ Composable all-in-one mail server.
https://maddy.email
GNU General Public License v3.0
5k stars 240 forks source link

Extract mapping lookup from loop #566

Closed arisudesu closed 1 year ago

arisudesu commented 1 year ago

Some repeated calls I've found while looking through prepare_email logic.

codecov-commenter commented 1 year ago

Codecov Report

Merging #566 (ff52e69) into master (9a87d73) will increase coverage by 0.00%. The diff coverage is 41.17%.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   52.89%   52.90%           
=======================================
  Files         126      126           
  Lines       12975    12977    +2     
=======================================
+ Hits         6863     6865    +2     
  Misses       5468     5468           
  Partials      644      644           
Flag Coverage Δ
integration 34.04% <41.17%> (+0.04%) :arrow_up:
unit 54.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/authz/lookup.go 48.14% <41.17%> (+4.14%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

foxcpp commented 1 year ago

Thanks!