search

foxcpp / maddy

✉️ Composable all-in-one mail server.
https://maddy.email
GNU General Public License v3.0
5.14k stars 249 forks source link

feat: add smtp auth login support #683

Closed buroa closed 3 months ago

buroa commented 9 months ago

This let's providers like smtp.office365.com work.

buroa commented 9 months ago

Extremely easy PR for you @foxcpp :)

foxcpp commented 9 months ago

Needs corresponding documentation update

buroa commented 9 months ago

@foxcpp Done!

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 52.38%. Comparing base (1d6cd8c) to head (a87a9c0).

Files Patch % Lines
internal/target/smtp/sasl.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #683 +/- ## ======================================= Coverage 52.38% 52.38% ======================================= Files 128 128 Lines 13382 13389 +7 ======================================= + Hits 7010 7014 +4 - Misses 5707 5711 +4 + Partials 665 664 -1 ``` | [Flag](https://app.codecov.io/gh/foxcpp/maddy/pull/683/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Max+Mazurov) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/foxcpp/maddy/pull/683/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Max+Mazurov) | `34.11% <0.00%> (-0.12%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/foxcpp/maddy/pull/683/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Max+Mazurov) | `53.76% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Max+Mazurov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

buroa commented 9 months ago

Let me add some tests as well @foxcpp.

buroa commented 9 months ago

@foxcpp Ready for you.

buroa commented 8 months ago

@foxcpp Can we get this merged?

buroa commented 3 months ago

@foxcpp Ping

buroa commented 3 months ago

Closing this. Doubt it'll be merged.