foxglove / ros-foxglove-bridge

Foxglove WebSocket bridge for ROS 1 and ROS 2
MIT License
154 stars 67 forks source link

Add ROS 2 dependency for ament_index_cpp #281

Closed clalancette closed 8 months ago

clalancette commented 8 months ago

Public-Facing Changes

None

Description

There is a direct dependency in this package to ament_index_cpp, so make sure to add it.

This should fix the failing build on Rolling: https://build.ros2.org/view/Rbin_uJ64/job/Rbin_uJ64__foxglove_bridge__ubuntu_jammy_amd64__binary/89/

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

clalancette commented 8 months ago

The smoke test failed on the Rolling build, but that seems unrelated to this pull request.

clalancette commented 8 months ago

Thanks for merging! When you get a chance, a new release into Rolling should fix the build there.

achim-k commented 8 months ago

-> https://github.com/ros/rosdistro/pull/39393