search

foxglove / schemas

Message schemas supported by Foxglove Studio
MIT License
55 stars 29 forks source link

Extending PointsAnnotation and CircleAnnotation with object_id #107

Closed markoSyrmia closed 1 year ago

markoSyrmia commented 1 year ago

I have added object_id in PointsAnnotation and CircleAnnotation.

Description

I need this change because i want to have possibility to send object id through protobuf message, in order to be able to display it on ImageView. This is only the first part, the second is contained in foxglove/studio repo.

I will post here link of PR (the second part from foxglove/studio repo), for better understanding why i need this changes. https://github.com/foxglove/studio/pull/5921

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jtbandes commented 1 year ago

Hi, What is the intended use case for the object id? I noticed that your other PR #109 references the object id being a simple label like "car" or "truck". Is it just a visual label, or do you want to tie the identifier to a particular instance of data?

markoSyrmia commented 1 year ago

To an extent the answer is Yes on bot counts. We wanted to implement the ability to "render" the object ID on screen, and also have it share object ID with other representations of the data in other views. So that the user can identify that the rectangle in Image view is the same object as a cube in 3D view.

jtbandes commented 1 year ago

For rendering the object ID on screen, have you tried TextAnnotation? For displaying additional data, would adding a metadata field (similar to SceneEntity) work for your use case?

jtbandes commented 1 year ago

We believe that TextAnnotations are the best way to achieve this feature.