Remove all mobx annotations and upgrade to mobx 6.3.3

foxhound87 / mobx-react-form

Reactive MobX Form State Management

https://foxhound87.github.io/mobx-react-form

MIT License

1.09k stars 129 forks source link

Closed rdgco closed 2 years ago

rdgco commented 2 years ago

This replaces all of the mobx annotations with explicit calls to makeObservable. This seems to work so far for my side project. This addresses the concerns here: https://github.com/foxhound87/mobx-react-form/issues/570#issue-828196693

Also this includes work done here in this unmerged PR: https://github.com/foxhound87/mobx-react-form/pull/571

Please provide feedback on any part of this PR.

foxhound87 commented 2 years ago

Thank you for your PR please replace all reference to rdgco from package.json with the original ones

jkeruzec commented 2 years ago

Voting for this one also ! to have full compatibility with newer version of MobX

New issue came with version 6.3.6. Now an error is thrown when mixing Decorators and makeObservable. https://github.com/mobxjs/mobx/pull/3154

foxhound87 commented 2 years ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: