foxhound87 / mobx-react-form

Reactive MobX Form State Management
https://foxhound87.github.io/mobx-react-form
MIT License
1.09k stars 129 forks source link

update() method creates fields even fallback is false #602

Closed riceyeh closed 2 years ago

riceyeh commented 2 years ago

The following test shows new field 'prop.id' is created when updating field 'p' even that the form's fallback option is false:

it('no fallback on separated mode - 2', () => {
  const fields = ['prop']
  const values = {
      prop: {
          id: 'id 1',
          desc: 'description 1'
      }
  }
  const form = new Form({fields, values}, {name: 'Form without fallback', options: {fallback: false}})
  expect(form.$('prop').value).to.deep.equal({
      id: 'id 1',
      desc: 'description 1'
  })
  form.$('prop').update({
      id: 'id 2',
      desc: 'description 2'
  })
  expect(form.select('prop.id', undefined, false)).to.be.undefined // fails. field prop.id is created
  expect(form.$('prop').value).to.deep.equal({  // fails, field prop's value is not changed
      id: 'id 2',
      desc: 'description 2'
  })
})
github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: